pyproject.toml (1)

7-7: Consider aligning development-status classifier with prerelease version.

Line 7 sets an alpha version (0.47.7a0), while Line 11 still declares Production/Stable. Consider switching classifier during prerelease cycles to avoid metadata ambiguity.

📦 Optional metadata alignment

-    "Development Status :: 5 - Production/Stable",
+    "Development Status :: 3 - Alpha",

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@pyproject.toml` at line 7, The package metadata declares a prerelease version
string ("version = \"0.47.7a0\"") but the classifiers still indicate a
production/stable release; update the Development Status classifier to match an
alpha prerelease (for example change "Development Status :: 5 -
Production/Stable" to "Development Status :: 3 - Alpha" or similar) so the
metadata aligns with the prerelease version; locate the classifiers block in
pyproject.toml and replace the Production/Stable entry with the appropriate
prerelease classifier.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

plugwise_usb/connection/manager.py (1)

137-143: ⚠️ Potential issue | 🟠 Major

Catch OSError to preserve the StickError boundary for serial-open failures.

Line 138 only catches FileNotFoundError; other open failures (e.g., permission/IO errors) can still leak as raw OSError subclasses instead of being normalized to StickError.

Suggested patch

-        except (
-            FileNotFoundError,
-            SerialException,
-            TimeoutError,
-            TypeError,
-            ValueError,
-        ) as err:
+        except (
+            OSError,
+            SerialException,
+            TimeoutError,
+            TypeError,
+            ValueError,
+        ) as err:
             raise StickError(
                 f"Failed to open serial connection to {serial_path}"
             ) from err

In serialx, what exceptions can create_serial_connection(...) raise when opening an invalid/unavailable serial URL (missing device, permission denied, malformed path)? Please include whether these are OSError subclasses.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugwise_usb/connection/manager.py` around lines 137 - 143, The except block
that currently catches (FileNotFoundError, SerialException, TimeoutError,
TypeError, ValueError) should also include OSError so serial-open failures
(permission/IO/malformed paths) are normalized to the StickError boundary;
update the tuple in the except (...) as err clause (the handler that raises or
wraps into StickError) to add OSError, ensuring the same error path is followed
for create_serial_connection/open attempts and preserve the StickError semantics
used elsewhere in the manager (refer to the existing SerialException and
StickError handling).

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

plugwise_usb/connection/manager.py (1)

124-140: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Catch TimeoutError from wait_for and re-raise as StickError.

At Line 128, wait_for(..., timeout=5) can raise TimeoutError, but Line 137 does not catch it. That can leak a raw timeout exception and break the StickError contract for setup failures.

Suggested fix

-        except (OSError, TypeError, ValueError) as err:
+        except (OSError, TimeoutError, TypeError, ValueError) as err:
             raise StickError(
                 f"Failed to open serial connection to {serial_path}"
             ) from err

#!/bin/bash
# Verify timeout path and exception mapping in manager.
rg -nP -C4 'wait_for\(|create_serial_connection\(|except\s+\(OSError,\s*TypeError,\s*ValueError\)' plugwise_usb/connection/manager.py

# Verify how callers handle setup_connection_to_stick failures.
rg -nP -C3 '\bsetup_connection_to_stick\s*\('

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@plugwise_usb/connection/manager.py` around lines 124 - 140, The wait_for call
in setup_connection_to_stick can raise TimeoutError which is not currently
caught, so update the exception handling around
wait_for/create_serial_connection in setup_connection_to_stick to also catch
TimeoutError (either add TimeoutError to the existing except tuple or add a
separate except TimeoutError as err) and re-raise it as a StickError with a
clear message that includes the serial_path, preserving the original exception
as the __cause__ (raise StickError(...) from err) so callers of
setup_connection_to_stick continue to receive StickError for all setup failures.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes